This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.17-106-gc0609c5


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  c0609c5c5e4b94f744ba952bb7d005bdd3684c71 (commit)
      from  6270516e154c389ac495153270918d06e41ed67d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sources.redhat.com/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=c0609c5c5e4b94f744ba952bb7d005bdd3684c71

commit c0609c5c5e4b94f744ba952bb7d005bdd3684c71
Author: Carlos O'Donell <codonell@redhat.com>
Date:   Fri Jan 11 20:52:05 2013 -0500

    Remove unnecessary assert on attr in allocate_stack().

diff --git a/nptl/ChangeLog b/nptl/ChangeLog
index 33152e2..4aacc17 100644
--- a/nptl/ChangeLog
+++ b/nptl/ChangeLog
@@ -1,3 +1,8 @@
+2013-01-11  Carlos O'Donell  <codonell@redhat.com>
+
+	* allocatestack.c (allocate_stack): Add comment. Remove assert
+	on attr.
+
 2013-01-11  H.J. Lu  <hongjiu.lu@intel.com>
 
 	* Makefile (tst-cancel7-ARGS: Replace $(host-built-program-cmd)
diff --git a/nptl/allocatestack.c b/nptl/allocatestack.c
index d1056ee..31c8829 100644
--- a/nptl/allocatestack.c
+++ b/nptl/allocatestack.c
@@ -340,6 +340,10 @@ change_stack_perm (struct pthread *pd
 }
 
 
+/* Returns a usable stack for a new thread either by allocating a
+   new stack or reusing a cached stack of sufficient size.
+   ATTR must be non-NULL and point to a valid pthread_attr.
+   PDP must be non-NULL.  */
 static int
 allocate_stack (const struct pthread_attr *attr, struct pthread **pdp,
 		ALLOCATE_STACK_PARMS)
@@ -349,7 +353,6 @@ allocate_stack (const struct pthread_attr *attr, struct pthread **pdp,
   size_t pagesize_m1 = __getpagesize () - 1;
   void *stacktop;
 
-  assert (attr != NULL);
   assert (powerof2 (pagesize_m1 + 1));
   assert (TCB_ALIGNMENT >= STACK_ALIGN);
 

-----------------------------------------------------------------------

Summary of changes:
 nptl/ChangeLog       |    5 +++++
 nptl/allocatestack.c |    5 ++++-
 2 files changed, 9 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]