This is the mail archive of the
gsl-discuss@sourceware.org
mailing list for the GSL project.
Re: [PATCH] Add Greville abscissae functionality to B-splines
- From: Patrick Alken <patrick dot alken at colorado dot edu>
- To: Rhys Ulerich <rhys dot ulerich at gmail dot com>
- Cc: gsl-discuss at sourceware dot org
- Date: Sat, 4 Jul 2009 19:09:57 -0600
- Subject: Re: [PATCH] Add Greville abscissae functionality to B-splines
- References: <20090614165708.22998.15238.stgit@localhost> <m3my894wt8.wl%bjg@network-theory.co.uk> <4a00655d0906150743h73d5d019w58a32db374861309@mail.gmail.com> <20090615173917.GA31020@hippogriff.homeunix.org> <4a00655d0906151113y5efb05a7gde0b73d7afc9d0bf@mail.gmail.com> <20090615183150.GA6198@hippogriff.homeunix.org> <4a00655d0906171454h411b717ao842bdb618513e3b9@mail.gmail.com>
I have committed this patch.
Patrick
On Wed, Jun 17, 2009 at 04:54:21PM -0500, Rhys Ulerich wrote:
> Hi Patrick (and all),
>
> Attached is a patch to apply atop my last Greville abscissae
> contribution. I had badly misunderstood some of the details when I
> implemented it originally. This new patch corrects the
> implementation, units tests, and documentation.
>
> - Rhys
>
> On Mon, Jun 15, 2009 at 1:31 PM, Patrick
> Alken<patrick.alken@colorado.edu> wrote:
> > Oops, I must have ran some autoconf tools and changed that file.
> > I think its fixed now.
> >
> > Patrick
> >
> > On Mon, Jun 15, 2009 at 01:13:32PM -0500, Rhys Ulerich wrote:
> >> Hi Patrick,
> >>
> >> I noticed in the commit there were changes made to install.sh
> >> (http://git.savannah.gnu.org/gitweb/?p=gsl.git;a=commit;h=ccccc3cb7630ea43bdf365bcbaec71e31f8aea91).
> >> ?Were those deliberate?
> >>
> >> - Rhys
> >>
> >> On Mon, Jun 15, 2009 at 12:39 PM, Patrick
> >> Alken<patrick.alken@colorado.edu> wrote:
> >> > Nice work, I have added your patch to the repository and
> >> > inserted the appropriate gsl_bspline_free's in test.c.
> >> >
> >> > Patrick
> >> >
> >> > On Mon, Jun 15, 2009 at 09:43:46AM -0500, Rhys Ulerich wrote:
> >> >> Thanks guys.
> >> >>
> >> >> FYI, I woke up this morning and realized I forgot a gsl_bspline_free
> >> >> call at the bottom of each of the unit test blocks in test.c.
> >> >>
> >> >> - Rhys
> >> >>
> >> >> On Mon, Jun 15, 2009 at 5:26 AM, Brian Gough<bjg@network-theory.co.uk> wrote:
> >> >> > At Sun, 14 Jun 2009 12:02:10 -0500,
> >> >> > Rhys Ulerich wrote:
> >> >> >> ?This change adds computing Greville abscissae to the GSL B-spline
> >> >> >> ?routines. ?Updates to unit tests and documentation are included.
> >> >> >> ?The routines are written so that if the b-spline classes have lower
> >> >> >> ?continuity basis added later (i.e. by adding multiple knots per
> >> >> >> ?interior breakpoint), these should continue to do the right thing.
> >> >> >
> >> >> > Cool. I'll let Patrick take care of these.
> >> >> >
> >> >> > --
> >> >> > Brian Gough
> >> >> >
> >> >> >
> >> >
> >