Re: Register Window Height Patch

[James Ingham <jingham at cygnus dot com>]

Steven,

That looks good, I will check it in.  One other point of protocol,
when you post patches, you should put a ChangeLog entry in the patch
submission.  BUT, you should not put it in the patch itself, since
ChangeLog patches almost never apply cleanly.  Instead, stick it in
the message just before the patch.

Don't worry about it this time - I will add one.  Just for the future.

Again, thanks for the patch.

Jim
 > Jim,
 >   I agree with you on the vertical height resizing. I did this as
 > something quick so that
 >   I can have a window higher than 16 which is too small when your CPU
 > has 165 registers.
 > 
 >   Thanks for the info, Following is a revised patch, that icorporates
 > your comments. 
 >   (Hopefully in a better format than the previous one)
 > 
 > Steven Johnson
 > 
 > 
 > diff -C2 -r ../gdb_cvs/src/gdb/gdbtk/library/prefs.tcl
 > src/gdb/gdbtk/library/prefs.tcl
 > *** ../gdb_cvs/src/gdb/gdbtk/library/prefs.tcl  Tue Mar 28 11:59:40 2000
 > --- src/gdb/gdbtk/library/prefs.tcl     Mon Apr  3 22:59:46 2000
 > ***************
 > *** 311,314 ****
 > --- 311,315 ----
 >     # Register Window
 >     pref define gdb/reg/highlight_fg        blue
 > +   pref define gdb/reg/rows                16
 >   
 >     # Global Prefs Dialogs
 > diff -C2 -r ../gdb_cvs/src/gdb/gdbtk/library/regwin.itb
 > src/gdb/gdbtk/library/regwin.itb
 > *** ../gdb_cvs/src/gdb/gdbtk/library/regwin.itb Wed Mar 29 09:04:13 2000
 > --- src/gdb/gdbtk/library/regwin.itb    Mon Apr  3 22:59:47 2000
 > ***************
 > *** 348,352 ****
 >   # ------------------------------------------------------------------
 >   body RegWin::dimensions {} {
 > !   set rows 16
 >     #    set rows [expr int(floor(sqrt($num_regs)))]
 >     set cols [expr {int(ceil(sqrt($num_regs)))}]
 > --- 348,352 ----
 >   # ------------------------------------------------------------------
 >   body RegWin::dimensions {} {
 > !   set rows [pref get gdb/reg/rows]
 >     #    set rows [expr int(floor(sqrt($num_regs)))]
 >     set cols [expr {int(ceil(sqrt($num_regs)))}]
 >