This is the mail archive of the
insight@sources.redhat.com
mailing list for the Insight project.
Re: comment in managedwin.itb
Tom Tromey wrote:
>
> Fernando> I guess you did not take it as approval. My only suggestion
> Fernando> is that you add your comments (what you say in between the
> Fernando> ------ below) in there so that no one goes and add a "focus"
> Fernando> back in that place.
>
> Fernando> Or do you think having "focus" in there is so absurd that
> Fernando> after you remove it no one will ever think of doing that?
>
> Nope.
>
> I deleted the code and added this comment:
>
> # There used to be a `focus -force' here, but using -force is
> # unfriendly, so it was removed. It was then replaced with a simple
> # `focus $top'. However, this has no useful effect -- it just
> # resets the subwindow of $top which has the `potential' focus.
> # This can actually be confusing to the user.
>
> I'm checking this in. If you want something more in the comment, tell
> me and I will add it.
>
Excelent! That would prevent regressions.
Thank you.
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9