This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch: Fix .gdbtkinit reading


On 21 Aug 2001, Tom Tromey wrote:

> Currently Insight tries to encode preference values which include `='.
> Unfortunately due to a small bug Insight doesn't properly re-read such
> values.
>
> I found this while trying to use a saved session.  I tested the
> appended patch on that session.  Ok to commit?

Looks pretty innocent to me. Did this fix your session problem, or do you
still need someone to look at it?

Keith

> Index: ChangeLog
> from  Tom Tromey  <tromey@redhat.com>
>
> 	* library/prefs.tcl (pref_read): Version number appears in
> 	comment.
>
> Index: library/prefs.tcl
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/prefs.tcl,v
> retrieving revision 1.11
> diff -u -r1.11 prefs.tcl
> --- library/prefs.tcl 2001/08/09 20:43:54 1.11
> +++ library/prefs.tcl 2001/08/21 21:39:37
> @@ -78,7 +78,8 @@
>  	  {^[ \t\n]*#.*} {
>  	    # Comment.  We recognize one magic comment that includes
>  	    # the version number.
> -	    if {[regexp -- "^GDBtkInitVersion: (\[0-9\]+)\$" $line v]} {
> +	    if {[regexp -- "^# GDBtkInitVersion: (\[0-9\]+)\$" $line \
> +		   dummy v]} {
>  	      set version $v
>  	    }
>  	  }
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]