Re: [RFA] debugwin behavior

["Martin M. Hunt" <hunt at redhat dot com>]

checked in.

Martin


On Monday 29 October 2001 05:59 pm, Keith Seitz wrote:
> On Mon, 29 Oct 2001, Martin M. Hunt wrote:
> > 1. If you close all the source windows, the DebugWin is stillhanging
> > around. I think it should exit when the last source window is closed.
> >
> > 2. If you exit Insight with a DebugWin open, its state is saved as an
> > active window in ~/.gdbtkinit and it will be reopened next time Insight
> > is started regardless of the setting of GDBTK_DEBUG.
>
> I'll be happy to see these finally go.
>
> Please commit, and thank you for your efforts.
> Keith
>
> > 2001-10-29  Martin M. Hunt  <hunt@redhat.com>
> >
> > 	* library/debugwin.itb: Don't increment number of
> > 	TopLevelWins.
> >
> > 	* library/managedwin.itb: Don't save DebugWins to
> > 	active list.
> >
> > Index: library/managedwin.itb
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/gdbtk/library/managedwin.itb,v
> > retrieving revision 1.17
> > diff -u -p -r1.17 managedwin.itb
> > --- managedwin.itb	2001/07/21 18:49:18	1.17
> > +++ managedwin.itb	2001/10/29 23:06:59
> > @@ -24,7 +24,6 @@ body ManagedWin::constructor {args} {
> >  #  PUBLIC METHOD: destructor
> >  # ------------------------------------------------------------
> >  body ManagedWin::destructor {} {
> > -
> >    # If no toplevels remain, quit.  However, check the quit_if_last
> >    # flag since we might be doing something like displaying a
> >    # splash screen at startup...
> > @@ -116,7 +115,7 @@ body ManagedWin::restart {} {
> >  body ManagedWin::shutdown {} {
> >    set activeWins {}
> >    foreach win [itcl_info objects -isa ManagedWin] {
> > -    if {![$win isa ModalDialog]} {
> > +    if {![$win isa ModalDialog] && ![$win isa DebugWin]} {
> >        set g [wm geometry [winfo toplevel [namespace tail $win]]]
> >        pref setd gdb/geometry/[namespace tail $win] $g
> >        lappend activeWins [$win pickle]
> > Index: library/debugwin.itb
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/gdbtk/library/debugwin.itb,v
> > retrieving revision 1.2
> > diff -u -p -r1.2 debugwin.itb
> > --- debugwin.itb	2001/02/08 19:26:31	1.2
> > +++ debugwin.itb	2001/10/29 23:06:59
> > @@ -26,7 +26,6 @@ body DebugWin::constructor {args} {
> >    window_name "Insight Debug" "Debug"
> >
> >    build_win
> > -  incr numTopWins
> >  }
> >
> >  #
> > -------------------------------------------------------------------------
> >----