This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Patch to fix Tk `make test` rule


It seems the `make test` rule does not work for the Tk version on sources.
The reason things are broken is that we have a local change that sets
TCL_BIN_DIR in the tcl/unix/tclConfig.sh file. After fixing the problem
in my local sources by removing the TCL_BIN_DIR from tclConfig.sh,
I got the odd feeling that I had already looked at this issue some time
in the past. A quick search turned up this thread.

http://sources.redhat.com/ml/insight/2001-q3/msg00062.html

The issue was never resolved and was left until after the 8.3
upgrade was finished. So here is the patch to really fix this
problem once and for all.

2002-07-14  Mo DeJong  <supermo@bayarea.net>

	* unix/configure: Regen.
	* unix/configure.in: Don't subst TCL_BIN_DIR into tclConfig.sh.
	* unix/tclConfig.sh.in: Remove TCL_BIN_DIR variable since it
	should not exist in the tclConfig.sh file. This variable
	should be set by the SC_PATH_TCLCONFIG macro when the
	extension's configure script is run.

Index: unix/configure.in
===================================================================
RCS file: /cvs/src/src/tcl/unix/configure.in,v
retrieving revision 1.5
diff -u -r1.5 configure.in
--- unix/configure.in	9 Sep 2001 23:56:09 -0000	1.5
+++ unix/configure.in	15 Jul 2002 05:46:02 -0000
@@ -591,7 +591,6 @@
 AC_SUBST(TCL_SHARED_LIB_SUFFIX)
 AC_SUBST(TCL_SHLIB_CFLAGS)
 AC_SUBST(TCL_SRC_DIR)
-AC_SUBST(TCL_BIN_DIR)
 AC_SUBST(TCL_UNSHARED_LIB_SUFFIX)
 AC_SUBST(TCL_VERSION)
 AC_SUBST(VENDORPREFIX)
Index: unix/tclConfig.sh.in
===================================================================
RCS file: /cvs/src/src/tcl/unix/tclConfig.sh.in,v
retrieving revision 1.4
diff -u -r1.4 tclConfig.sh.in
--- unix/tclConfig.sh.in	9 Sep 2001 23:56:09 -0000	1.4
+++ unix/tclConfig.sh.in	15 Jul 2002 05:46:03 -0000
@@ -45,9 +45,6 @@
 # The name of the Tcl library (may be either a .a file or a shared library):
 TCL_LIB_FILE='@TCL_LIB_FILE@'
 
-# The directory the Tcl binaries are being built to.
-TCL_BIN_DIR='@TCL_BIN_DIR@'
-
 # The fullpath of the Tcl library (used for dependency checking)
 TCL_LIB_FULL_PATH='@TCL_LIB_FULL_PATH@'
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]