This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Make cli-out follow gdb_stdout

FYI,

This:


 struct ui_out_data
   {
-    struct ui_file *stream;
+    struct ui_file **stream;
     int suppress_output;
   };

and this:


-      uiout = cli_out_new (gdb_stdout);
+      uiout = cli_out_new (&gdb_stdout);
worry me.

The intent is to eventually have everything using a parameterized output object - if you want to change where output goes, change the parameter. Given that, having stuff depend on an indirect global pointer looks to be going in the wrong direction.

I'll need to look over the problems that Pierre was trying to solve.

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]