This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] `insight -i=gdbtk' works


On Wed, 2003-02-12 at 08:13, Andrew Cagney wrote:

./insight -nx -i=gdbtk
./gdb -nw -i=gdbtk

it dumps core. If you haven't guessed, the missing bit involves gdbtk_init(), init_ui_hook and use_windows.

Turns out that we're barking up the same tree. Except my version doesn't
crash at all, but it also doesn't honor "-nw". I have a feeling this is
going to be a messy/hacky fix.

Anyway, I'll see about merging our two implementations. (I also
submitted a patch against gdb so that when users run "insight", they implicitly get "-i=insight". A bigger "problem" will be keeping the
symmetry with "gdb -w". That won't work, either, but, then again, maybe
it shouldn't. We are trying to get gdb it's own isolated executable,
right? [Reminds me... I think I have patches somewhere to do this --
updates the init.c process and adds options parsing...]
I'm pretty sure that with your main.c change in (and gdbtk.c changed to register "insight" instead of "gdbtk", insight will at least `work'.

That just leaves the core dump which is comming from gdbtk_init() not being called in all cases :-( There, the fix, I think, involves modifying the interps.h:init interface so that it takes an argv0 parameter.

As for -nw, yes, that needs some thought. Thinking out loud, should the option even remain? Or turn into an alias - `-nw' -> `-i=console'; `-w' -> `-i=gui' (and have insight register `gui' as an interpreter)? Or, become an attribute that is used when selecting the initial interpreter? Something to discuss on the gdb@ as --tui has the same problem.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]