This is the mail archive of the insight@sources.redhat.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gdb/Insight 5.3 really slow when stepping - patch submitted togdb-patch list


On Fri, 2003-05-23 at 05:57, Roland Schwingel wrote:

> Finally when looking at gdb_find_file_command() which calls this
> lookup_symtab() on every step, I saw that the sole purpose
> of this function appears to be getting the full path of a file. When
> stepping all the time the pathname was already fully qualified, so
> when this is the case just check the presence of the file and then
> return with the filename as full name if ok. Elsewise go the regular
> way using lookup_symtab(). That is what my patch is doing now. I
> think gdbtk uses this on every step to determin whether a file has
> changed or not.

I'll have to think about this, but when you put it that way, it does
rather sound like the stat idea isn't altogether out of place. Let me
give it some thought.

> Yes I use the current gdb of cygwin (20030303), with a bunch of changes
> to allow Objective C debugging. But it is also slow without these changes.

Hmm. Maybe there's a problem in the symbol readers for ObjC? Maybe
there's just TONS of symbols. Admittedly, I don't use Insight for much
else other than small dynamic modules and gdb itself. So maybe your
large environment is causing the problems, too. (Sigh -- there's no easy
way to know, is there?) In any case, it seems like short-circuiting
lookup_symtab in gdb_find_file might be appropriate.

> PS: I fixed another bug in gdbtk, where the filecombobox in the sourcewindow
>      is not always showing all files. After doing a dynamic load the filenames
>      which are brought by the newly loaded lib where missing.The fix apears
>      to be easy. Where should I direct it to (the insight list or gdb-patch)?

Yes, submit to this (insight) list. I officially own libgui (see
src/MAINTIANERS). Unless the patch is pretty trivial, you will need an
FSF assignment... 

Keith



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]