This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
Re: Parallel install insight 6.6 fails
On 3/24/07, Keith Seitz <keiths@redhat.com> wrote:
Jie Zhang wrote:
>> http://sources.redhat.com/ml/insight-prs/2007-q1/msg00006.html
>>
> I finally got a fix for this parallel install bug. Where should I send
> the patch, insight or itcl? Is there any copyright stuff I need do
> before contributing to insight?
You can attach the patch to the bug. I believe I am responsible for tcl
et al in the repository. If the patch is relatively trivial, you don't
need an assignment of any kind.
The insight bug database is not easy to use for me. So I attach the
patch in the email.
This patch only change 2 lines. So I think it's trivial. This patch
makes install-libraries target depend on installdirs target for itcl
and itk, which will ensure that $(ITCL_LIBRARY) directory is created
before install-libraries tries to install libraries in it.
Do you know if this bug exists upstream at all? If you have the time, I
would encourage you to investigate this.
I checked out the source code from
incrtcl.cvs.sourceforge.net:/cvsroot/incrtcl. It seems this bug does
not exist. The itcl in insight is 5.5 year older than the upsteam...
Jie
2007-03-23 Jie Zhang <jie.zhang@analog.com>
* itk/Makefile.in (install-libraries): Depends on installdirs.
* itcl/Makefile.in (install-libraries): Likewise.
Index: itcl/itk/Makefile.in
===================================================================
--- itcl/itk/Makefile.in (revision 1530)
+++ itcl/itk/Makefile.in (working copy)
@@ -266,7 +266,7 @@
# This rule installs platform-independent files, such as header files.
#========================================================================
-install-libraries: libraries
+install-libraries: libraries installdirs
$(mkinstalldirs) $(includedir)
@echo "Installing header files in $(includedir)"
@for i in $(GENERIC_HDRS) ; do \
Index: itcl/itcl/Makefile.in
===================================================================
--- itcl/itcl/Makefile.in (revision 1530)
+++ itcl/itcl/Makefile.in (working copy)
@@ -271,7 +271,7 @@
# This rule installs platform-independent files, such as header files.
#========================================================================
-install-libraries: libraries
+install-libraries: libraries installdirs
$(mkinstalldirs) $(includedir)
@echo "Installing header files in $(includedir)"
@for i in $(GENERIC_HDRS) ; do \