[RFA] ARI fixes for gdbtk directories

["Pierre Muller" <muller at ics dot u-strasbg dot fr>]

A few more ARI fixes for gdbtk.

Is this OK?


Pierre Muller
Pascal language support maintainer for GDB





2009-04-07  Pierre Muller  <muller.u-strasbg.fr²>

	ARI fixes: xvasprintf and strdup rules.
	* generic/gdbtk-cmds.c (gdbtk_set_result): Replace xvasprintf by
	xstrvprintf.
	* generic/gdbtk-hooks.c (gdbtk_warning): Ditto.
	(gdbtk_readline_begin, gdbtk_query): Ditto.
	* generic/gdbtk.c (TclDebug): Ditto.
	* generic/gdbtk-varobj.c (variable_create): Replace strdup by
xstrdup.

Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.107
diff -u -p -r1.107 gdbtk-cmds.c
--- generic/gdbtk-cmds.c	25 Mar 2009 23:43:07 -0000	1.107
+++ generic/gdbtk-cmds.c	6 Apr 2009 22:20:33 -0000
@@ -2911,7 +2911,7 @@ gdbtk_set_result (Tcl_Interp *interp, co
   char *buf;
 
   va_start (args, fmt);
-  xvasprintf (&buf, fmt, args);
+  buf = xstrvprintf (, fmt, args);
   va_end (args);
   Tcl_SetObjResult (interp, Tcl_NewStringObj (buf, -1));
   xfree(buf);
Index: generic/gdbtk-hooks.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v
retrieving revision 1.47
diff -u -p -r1.47 gdbtk-hooks.c
--- generic/gdbtk-hooks.c	25 Mar 2009 23:43:07 -0000	1.47
+++ generic/gdbtk-hooks.c	6 Apr 2009 22:20:33 -0000
@@ -348,7 +348,7 @@ static void
 gdbtk_warning (const char *warning, va_list args)
 {
   char *buf;
-  xvasprintf (&buf, warning, args);
+  buf = xstrvprintf (, warning, args);
   gdbtk_two_elem_cmd ("gdbtk_tcl_warning", buf);
   free(buf);
 }
@@ -488,7 +488,7 @@ gdbtk_readline_begin (char *format,...)
   char *buf;
 
   va_start (args, format);
-  xvasprintf (&buf, format, args);
+  buf = xstrvprintf (, format, args);
   gdbtk_two_elem_cmd ("gdbtk_tcl_readline_begin", buf);
   free(buf);
 }
@@ -684,7 +684,7 @@ gdbtk_query (const char *query, va_list 
   char *buf;
   long val;
 
-  xvasprintf (&buf, query, args);
+  buf = xstrvprintf (, query, args);
   gdbtk_two_elem_cmd ("gdbtk_tcl_query", buf);
   free(buf);
 
Index: generic/gdbtk.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk.c,v
retrieving revision 1.48
diff -u -p -r1.48 gdbtk.c
--- generic/gdbtk.c	25 Mar 2009 23:43:07 -0000	1.48
+++ generic/gdbtk.c	6 Apr 2009 22:20:34 -0000
@@ -215,7 +215,7 @@ TclDebug (char level, const char *fmt,..
   va_start (args, fmt);
 
 
-  xvasprintf (&buf, fmt, args);
+  buf = xstrvprintf (, fmt, args);
   va_end (args);
 
   v[0] = "dbug";
Index: generic/gdbtk-varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-varobj.c,v
retrieving revision 1.22
diff -u -p -r1.22 gdbtk-varobj.c
--- generic/gdbtk-varobj.c	14 Jul 2008 23:43:36 -0000	1.22
+++ generic/gdbtk-varobj.c	6 Apr 2009 22:20:33 -0000
@@ -323,7 +323,7 @@ variable_create (Tcl_Interp *interp, int
   else
     {
       /* specified name for object */
-      obj_name = strdup (name);
+      obj_name = xstrdup (name);
       objv++;
       objc--;
     }