This is the mail archive of the insight@sourceware.org mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [OBV] Fix Build gdbtk-cmds.c get error


On 06/18/2010 03:24 PM, Pierre Muller wrote:
I checked the following in:
   Note that it fixes the val_print problem
and also cygwin specific problems to
allow compilation with both 1.5 and 1.7 cygwin...

Aside from the cygwin stuff, I had a similar patch that I simply forgot to check in. Thank you for beating me to it! :-)


   For the cygwin_conv_path function,
I used the same macros as in gdb/windows-nat.c source.

   Please feel free to suggest better
fixes.

That all looks okay. If anything is amiss, it can be addressed in time.


   I didn't dare to change
GDB_val_print function, as this could have implications
for tcl/tk scripts... Am I right on this?

GDB_val_print is simply a wrapper which prevents gdb from longjmp'ing out of the Tcl interpreter. With the advent of "exceptions," the wrappers aren't really necessary any more. Maybe I'll clean this up some time...


PS: I only fixed compilation and I am still unable to
really test cygwin insight :(

I can see if my twelve year old box still boots and give it a quick sanity check.


Thanks again for the patch,
Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]