This is the mail archive of the insight@sourceware.org mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add missing prototype in gdbtk.c


On 03/19/2012 05:10 AM, Roland Schwingel wrote:
Changelog:

2012-03-19 Roland Schwingel <roland.schwingel@onevision.com>

* generic/gdbtk.c: Add prototype for close_bfds().

Any comments? Is this ok?

Hmm. There already appears to be a declaration for this in gdbtk.h:


#ifdef _WIN32
extern void close_bfds ();
#endif /* _WIN32 */

Perhaps that check needs updating to "#if defined(_WIN32) || defined(_WIN64)"?

[Consider that change pre-approved with updated ChangeLog entry.]

Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]