This is the mail archive of the
kawa@sourceware.org
mailing list for the Kawa project.
Re: FORMAT prefix parameter '#' not handled properly
On 10/07/2011 03:23 PM, Jamison Hope wrote:
It's a tabs-vs-spaces issue. The original file has a single tab on the
"int index =" line, and 5 tabs (and no spaces) on the following line.
The rest of the code base is already inconsistent about it (heck, the
rest of that *file* isn't consistent), so I wouldn't worry about it too
much. Maybe one of these days I'll M-x untabify all of Kawa and send Per
a huge patch that touches practically every file...
The old GNU standard was to use tabs, but I now think they're to be avoided.
(I think the only good reason to use tabs is if you make the indentation
increment a single tab, and then people can customize the indentation by
tweaking the display width of a tab.) So as we make changes, tabs get
replaced by spaces. Not sure wholesale tab replacement is a good idea (it
breaks "svn annotate" for one), but certainly if most of a method has
been de-tabbed, perhaps it makes sense finish the job.
Though of course now I'm slowly migrating away from "gnu" style to
more common "java" style, so we have an even bigger inconsistency ...
--
--Per Bothner
per@bothner.com http://per.bothner.com/