This is the mail archive of the kawa@sourceware.org mailing list for the Kawa project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
This seems cleaner:
Declaration decl = tr.lookup(name, Language.FUNCTION_NAMESPACE);
ReferenceExp rexp = new ReferenceExp(name, decl);
rexp.setProcedureName(true);
I do think doing setProcedureName is reasonable also when we find the declaration. Even if the flag isn't needed, it just seems more consistent.
Agreed. If the lookup fails, then rexp.binding will just be null, which is the same situation we had before.
Is that a valid change to make?
Seems reasonable.
I *think* that calling tr.lookup() from
within function.rewriteForm() will do the appropriate lexical search,
but I'm still a little fuzzy about what's supposed to happen when in the
various Syntax methods.
You think *I'm* not a little fuzzy on what's supposed to happen? :-)
-- Jamison Hope The PTR Group www.theptrgroup.com
Attachment:
gnu-commonlisp-lang.patch
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |