This is the mail archive of the
kawa@sourceware.org
mailing list for the Kawa project.
Re: Patch for wrong no declaration seen for command-line-arguments
- From: Matthieu Vachon <matthieu dot o dot vachon at gmail dot com>
- To: Charles Turner <chturne at gmail dot com>
- Cc: "kawa at sourceware dot org" <kawa at sourceware dot org>
- Date: Thu, 12 Sep 2013 16:20:09 -0400
- Subject: Re: Patch for wrong no declaration seen for command-line-arguments
- Authentication-results: sourceware.org; auth=none
- References: <CAOTvmo=VWjMv2Etk9gagPTAa2OgnM-3XG9USdLWrARbJ22dTcg at mail dot gmail dot com> <CAPMhJv2_=8y0khGb-ADSNmU-f8yeZ4OQvmmyt1w2ofDrzDVZbQ at mail dot gmail dot com>
Hi Charles,
Thank you for the procedure. I'm going to check this out later tonight.
As for the failed tests, I'm going to take a look.
Regards,
Matt
On Thu, Sep 12, 2013 at 4:09 PM, Charles Turner <chturne@gmail.com> wrote:
> Hi Matt,
>
> I can't comment on the patch as I haven't been following along.
>
> The test scripts you've written can be installed by adding the
> filenames (in this case unknown1.scm and unknown2.scm) to the
> testsuite/Makefile.am file.Specifically, add them to the variable
> SCRIPTS_TO_RUN. You then need to regenerate the Makefiles using
> autotools. I'm no expert, but aclocal && autoreconf has worked for me
> in the past from the top-level kawa directory. If you then do a make
> check, your tests will be run. For your patch, I got the following
> results:
>
> # unknown1.scm passes
> FAIL unknown2.scm: expected more diagnostics: \Qunknown2.scm:2:16:
> warning - no declaration seen for command-line-arguments\E
> # unknown2.scm fails
>
> Which will require further investigation.
>
> Hope that helps,
> Charles.
>
>
> On 12/09/2013, Matthieu Vachon <matthieu.o.vachon@gmail.com> wrote:
>> Hi Per,
>>
>> Here my try at fixing the incorrect warning that occurs when
>> generating a main method and using the `command-line-arguments`. It's
>> probably not the optimal way to fix the issue but I hope it is good
>> enough to be included in the trunk.
>>
>> I added two test cases but I'm unsure if the syntax I used is right.
>> Talking about that, what is the procedure to run the test suite? I
>> would like to know so I can test my patches when developing them prior
>> to sending them to you.
>>
>> Regards,
>> Matt
>>