This is the mail archive of the libc-alpha@cygnus.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: glibc-2.0.99 build problems


> Cc: howarth@bromo.med.uc.edu, libc-alpha@cygnus.com,
>         geoffk@geoffk.wattle.id.au
> Reply-To: drepper@cygnus.com (Ulrich Drepper)
> From: Ulrich Drepper <drepper@cygnus.com>
> Date: 27 Oct 1998 12:26:06 -0800
> 
> Geoff Keating <geoffk@ozemail.com.au> writes:
> 
> > This is a multiple-choice patch.  Please choose one of the two below.
> > I think the first is the more correct choice, because this is how the
> > functions are declared in the kernel source.
> 
> We cannot cheat on the INLINE_SYSCALL macro and simply pass a 64bit
> value.  Therefore this patch is out.  I haven't applied your previous
> patch for this exact reason.

Then please choose the second patch, attached below, and I will
declare that INLINE_SYSCALL on ppc must be able to cope with a 64bit
value where appropriate; it's just one of the complexities of the PPC
calling sequence.  I have changed the patch slightly to add some
documentation to sysdep.h.

How does Alpha handle this?  Does pread() currently work on Alpha?

-- 
Geoffrey Keating <geoffk@ozemail.com.au>

===File ~/patches/pwrite-2.patch============================
Index: pread.c
===================================================================
RCS file: /glibc/cvsfiles/libc/sysdeps/unix/sysv/linux/powerpc/pread.c,v
retrieving revision 1.1
diff -u -r1.1 pread.c
--- pread.c	1998/10/20 23:55:36	1.1
+++ pread.c	1998/10/27 19:57:15
@@ -1 +1,58 @@
-#include <sysdeps/unix/sysv/linux/i386/pread.c>
+/* Copyright (C) 1997, 1998 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+   Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Library General Public License as
+   published by the Free Software Foundation; either version 2 of the
+   License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Library General Public License for more details.
+
+   You should have received a copy of the GNU Library General Public
+   License along with the GNU C Library; see the file COPYING.LIB.  If not,
+   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  */
+
+#include <errno.h>
+#include <unistd.h>
+
+#include <sysdep.h>
+#include <sys/syscall.h>
+
+#ifdef __NR_pread
+
+extern ssize_t __syscall_pread (int fd, void *buf, size_t count,
+				off64_t offset);
+
+static ssize_t __emulate_pread (int fd, void *buf, size_t count,
+				off_t offset) internal_function;
+
+
+ssize_t
+__pread (fd, buf, count, offset)
+     int fd;
+     void *buf;
+     size_t count;
+     off_t offset;
+{
+  ssize_t result;
+
+  /* First try the syscall.  */
+  result = INLINE_SYSCALL (pread, 4, fd, buf, count, (off64_t)offset);
+  if (result == -1 && errno == ENOSYS)
+    /* No system call available.  Use the emulation.  */
+    result = __emulate_pread (fd, buf, count, offset);
+
+  return result;
+}
+
+weak_alias (__pread, pread)
+
+#define __pread(fd, buf, count, offset) \
+     static internal_function __emulate_pread (fd, buf, count, offset)
+#endif
+#include <sysdeps/posix/pread.c>
Index: pread64.c
===================================================================
RCS file: /glibc/cvsfiles/libc/sysdeps/unix/sysv/linux/powerpc/pread64.c,v
retrieving revision 1.1
diff -u -r1.1 pread64.c
--- pread64.c	1998/10/20 23:55:42	1.1
+++ pread64.c	1998/10/27 19:57:15
@@ -1 +1,58 @@
-#include <sysdeps/unix/sysv/linux/i386/pread64.c>
+/* Copyright (C) 1997, 1998 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+   Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Library General Public License as
+   published by the Free Software Foundation; either version 2 of the
+   License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Library General Public License for more details.
+
+   You should have received a copy of the GNU Library General Public
+   License along with the GNU C Library; see the file COPYING.LIB.  If not,
+   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  */
+
+#include <errno.h>
+#include <unistd.h>
+
+#include <sysdep.h>
+#include <sys/syscall.h>
+
+#ifdef __NR_pread
+
+extern ssize_t __syscall_pread (int fd, void *buf, size_t count,
+				off64_t offset);
+
+static ssize_t __emulate_pread64 (int fd, void *buf, size_t count,
+				  off64_t offset) internal_function;
+
+
+ssize_t
+__pread64 (fd, buf, count, offset)
+     int fd;
+     void *buf;
+     size_t count;
+     off64_t offset;
+{
+  ssize_t result;
+
+  /* First try the syscall.  */
+  result = INLINE_SYSCALL (pread, 4, fd, buf, count, offset);
+  if (result == -1 && errno == ENOSYS)
+    /* No system call available.  Use the emulation.  */
+    result = __emulate_pread64 (fd, buf, count, offset);
+
+  return result;
+}
+
+weak_alias (__pread64, pread64)
+
+#define __pread64(fd, buf, count, offset) \
+     static internal_function __emulate_pread64 (fd, buf, count, offset)
+#endif
+#include <sysdeps/posix/pread64.c>
Index: pwrite.c
===================================================================
RCS file: /glibc/cvsfiles/libc/sysdeps/unix/sysv/linux/powerpc/pwrite.c,v
retrieving revision 1.1
diff -u -r1.1 pwrite.c
--- pwrite.c	1998/10/20 23:56:01	1.1
+++ pwrite.c	1998/10/27 19:57:15
@@ -1 +1,58 @@
-#include <sysdeps/unix/sysv/linux/i386/pwrite.c>
+/* Copyright (C) 1997, 1998 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+   Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Library General Public License as
+   published by the Free Software Foundation; either version 2 of the
+   License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Library General Public License for more details.
+
+   You should have received a copy of the GNU Library General Public
+   License along with the GNU C Library; see the file COPYING.LIB.  If not,
+   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  */
+
+#include <errno.h>
+#include <unistd.h>
+
+#include <sysdep.h>
+#include <sys/syscall.h>
+
+#ifdef __NR_pwrite
+
+extern ssize_t __syscall_pwrite64 (int fd, const void *buf, size_t count,
+				   off64_t offset);
+
+static ssize_t __emulate_pwrite (int fd, const void *buf, size_t count,
+				 off_t offset) internal_function;
+
+
+ssize_t
+__pwrite (fd, buf, count, offset)
+     int fd;
+     const void *buf;
+     size_t count;
+     off_t offset;
+{
+  ssize_t result;
+
+  /* First try the syscall.  */
+  result = INLINE_SYSCALL (pwrite, 4, fd, buf, count, (off64_t)offset);
+  if (result == -1 && errno == ENOSYS)
+    /* No system call available.  Use the emulation.  */
+    result = __emulate_pwrite (fd, buf, count, offset);
+
+  return result;
+}
+
+weak_alias (__pwrite, pwrite)
+
+#define __pwrite(fd, buf, count, offset) \
+     static internal_function __emulate_pwrite (fd, buf, count, offset)
+#endif
+#include <sysdeps/posix/pwrite.c>
Index: pwrite64.c
===================================================================
RCS file: /glibc/cvsfiles/libc/sysdeps/unix/sysv/linux/powerpc/pwrite64.c,v
retrieving revision 1.1
diff -u -r1.1 pwrite64.c
--- pwrite64.c	1998/10/20 23:55:54	1.1
+++ pwrite64.c	1998/10/27 19:57:16
@@ -1 +1,58 @@
-#include <sysdeps/unix/sysv/linux/i386/pwrite64.c>
+/* Copyright (C) 1997, 1998 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+   Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Library General Public License as
+   published by the Free Software Foundation; either version 2 of the
+   License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Library General Public License for more details.
+
+   You should have received a copy of the GNU Library General Public
+   License along with the GNU C Library; see the file COPYING.LIB.  If not,
+   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  */
+
+#include <errno.h>
+#include <unistd.h>
+
+#include <sysdep.h>
+#include <sys/syscall.h>
+
+#ifdef __NR_pwrite
+
+extern ssize_t __syscall_pwrite64 (int fd, const void *buf, size_t count,
+				   off64_t offset);
+
+static ssize_t __emulate_pwrite64 (int fd, const void *buf, size_t count,
+				   off64_t offset) internal_function;
+
+
+ssize_t
+__pwrite64 (fd, buf, count, offset)
+     int fd;
+     const void *buf;
+     size_t count;
+     off64_t offset;
+{
+  ssize_t result;
+
+  /* First try the syscall.  */
+  result = INLINE_SYSCALL (pwrite, 4, fd, buf, count, offset);
+  if (result == -1 && errno == ENOSYS)
+    /* No system call available.  Use the emulation.  */
+    result = __emulate_pwrite64 (fd, buf, count, offset);
+
+  return result;
+}
+
+weak_alias (__pwrite64, pwrite64)
+
+#define __pwrite64(fd, buf, count, offset) \
+     static internal_function __emulate_pwrite64 (fd, buf, count, offset)
+#endif
+#include <sysdeps/posix/pwrite64.c>
Index: sysdep.h
===================================================================
RCS file: /glibc/cvsfiles/libc/sysdeps/unix/sysv/linux/powerpc/sysdep.h,v
retrieving revision 1.7
diff -u -r1.7 sysdep.h
--- sysdep.h    1998/05/29 10:20:50     1.7
+++ sysdep.h    1998/10/29 01:22:19
@@ -141,4 +141,13 @@
 #undef L
 #define L(x) .L##x
 
+#else   /* __ASSEMBLER__ */
+
+/* This is where you would declare INLINE_SYSCALL.
+   On PPC, it doesn't seem that defining this macro would provide any
+   space or time savings, so it is left undefined.
+   However, if you do define it, be aware that it must be able to cope
+   with some of the parameters being 'long long', and handle the padding
+   and so on required.  See p{read,write}{,64}.c for an example.  */
+
 #endif /* __ASSEMBLER__ */
============================================================


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]