This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [patch] fix multi-line string warnings for sparc64
- To: Ben Collins <bcollins at debian dot org>
- Subject: Re: [patch] fix multi-line string warnings for sparc64
- From: Andreas Jaeger <aj at suse dot de>
- Date: 30 Apr 2001 08:30:01 +0200
- Cc: GNU C Library <libc-alpha at sourceware dot cygnus dot com>
- References: <20010429192136.C435@visi.net>
Ben Collins <bcollins@debian.org> writes:
> Just some gcc-3.0 multi-line strings warnings...
>
> 2001-04-29 Ben Collins <bcollins@debian.org>
>
> * sysdeps/sparc/sparc64/dl-machine.h: fix multiline strings
> warnings
> * sysdeps/sparc/sparc64/soft-fp/qp_add.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_cmp.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_cmpe.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_div.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_dtoq.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_feq.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_fge.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_fgt.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_fle.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_flt.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_fne.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_mul.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_qtod.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_qtoi.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_qtos.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_qtoui.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_qtoux.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_qtox.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_qtox.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_sqrt.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_stoq.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/qp_sub.c: Likewise
> * sysdeps/sparc/sparc64/soft-fp/sfp-machine.h: Likewise
Please capitalize and add a period at the end next time.
I prefer the following:
# define ELF_MACHINE_RUNTIME_TRAMPOLINE asm ("\
.text\n\
.globl _dl_runtime_resolve\n\
instead of your:
+#define RTLD_START __asm__ ( "\n" \
+" .text\n" \
+" .global _start\n" \
+" .type _start, @function\n" \
+" .align 32\n" \
Jakub, what's your opinion? Shall I commit this?
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj