This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] Make ldconfig more quiet again
Jakub Jelinek <jakub@redhat.com> writes:
> On Mon, May 07, 2001 at 12:15:04PM -0700, H . J . Lu wrote:
> > On Mon, May 07, 2001 at 09:07:40PM +0200, Andreas Jaeger wrote:
> > >
> > > Two questions:
> > > - wouldn't it be better to cache the needed stat information in struct
> > > dir_entry?
> >
> > I don't think speed is critical for ldconfig. On the other hand,
> > it is not a bad idea.
>
> Speed is very critical for ldconfig, think about installations.
>
> Your patch has made ldconfig unnecessarily verbose under normal
> situations (e.g. having a non-existant directory in ld.so.conf would only
> print warning with -v, now it is unconditional, even worse if you have a
> stale symlink (such as because of package installation/removal in progress
> where e.g. libfoo.so is still present but the library it points to has been
> removed already), you'll get a warning as well.
>
> Here is a fix:
Jakub, thanks for catching and fixing this, I've committed it.
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj