This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch: Linuxthreads is broken.


On Sat, Jun 16, 2001 at 05:39:00PM -0700, Ulrich Drepper wrote:
> "H . J . Lu" <hjl@lucon.org> writes:
> 
> > Linuxthreads is broken due to the stack change. Here is a patch.
> 
> Unless you add real explanations I'm ignoring all your "reports".
> This is simply not acceptable.
> 

I thought my patch itself should have given you a clue. You should know
better before checking in the change:

2001-03-23  Matthew Wilcox  <willy@ldl.fc.hp.com>

        * attr.c: Make _STACK_GROWS_UP work.
        * internals.h: Likewise.
        * manager.c: Likewise.
        * pthread.c: Likewise.

You cannot check _STACK_GROWS_DOWN in internals.h without including
<stackinfo.h>. It may break any .c files which includes internals.h,
but not including <stackinfo.h> first. If we include <stackinfo.h> in
internals.h, there is no need to include <stackinfo.h> in each .c
file.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]