This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
[PATCH] Fix missing argument in linuxthreads/pthread.c
- From: Art Haas <ahaas at airmail dot net>
- To: libc-alpha at sources dot redhat dot com
- Date: Sat, 21 Dec 2002 20:13:56 -0600
- Subject: [PATCH] Fix missing argument in linuxthreads/pthread.c
Hi.
The __builtin__expect() function is missing the second argument. I don't
know if '1' as a suitable value or not, but some value is required.
2002-12-21 Art Haas <ahaas@airmail.net>
* pthread.c (init_rtsigs): Add second argument to
__builtin_expect.
Index: pthread.c
===================================================================
RCS file: /cvs/glibc/libc/linuxthreads/pthread.c,v
retrieving revision 1.111
diff -u -r1.111 pthread.c
--- pthread.c 18 Dec 2002 01:34:49 -0000 1.111
+++ pthread.c 22 Dec 2002 02:09:35 -0000
@@ -194,7 +194,7 @@
if (rtsigs_initialized)
return;
- if (__builtin_expect (__libc_current_sigrtmin_private () == -1))
+ if (__builtin_expect ((__libc_current_sigrtmin_private () == -1), 1))
{
__pthread_sig_restart = SIGUSR1;
__pthread_sig_cancel = SIGUSR2;
--
They that can give up essential liberty to obtain a little temporary safety
deserve neither liberty nor safety.
-- Benjamin Franklin, Historical Review of Pennsylvania, 1759