This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] PPC32 cancellation support
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Sat, 4 Jan 2003 21:33:23 +0100
- Subject: Re: [PATCH] PPC32 cancellation support
- References: <200301041706.01642@enzo.bigblue.local>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sat, Jan 04, 2003 at 05:06:01PM +0100, Franz Sirl wrote:
> * linuxthreads/sysdeps/unix/sysv/linux/powerpc/powerpc32/sysdep-cancel.h:
> New file.
Thanks for working on this.
> * sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list: Mark
> __syscall_pread64 and __syscall_pwrite64 cancellable.
IMHO the cancellation wrappers belong to linux/powerpc/{pread,pwrite}.c,
not to the __syscall_ stubs (ie. include sysdep-cancel.h instead of sysdep.h
in the C code and use LIBC_CANCEL_ASYNC and LIBC_CANCEL_RESET macros
together with SINGLE_THREAD_P.
Also, why doesn't it use INLINE_SYSCALL?
Jakub