This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: make existing mips files multi-ABI


Alexandre Oliva <aoliva at redhat dot com> writes:

> On Apr  5, 2003, Andreas Jaeger <aj at suse dot de> wrote:
>
>> Alexandre Oliva <aoliva at redhat dot com> writes:
>>> +/* As tempting as it is to define this, the userland data structures
>>> +   are not identical, because of different padding.  Perhaps they
>>> +   should be?  */

This last sentence above and the comment below.


>>> +/* # define XSTAT_IS_XSTAT64 1 */
>
>> Please remove that comment and the last sentence of the define.
>
> You mean, remove all of what you quoted above, along with the
> enclosing #if/#endif (that would then be empty)?  I thought it would

No.  The lines above should just be:
+/* As tempting as it is to define this, the userland data structures
+   are not identical, because of different padding.  */

Nothing more.

> be good to document why we can't use xstat for xstat64, since I myself
> must have thought of it a number of times, and actually tried it at
> least twice before believing it couldn't be used :-)
>
>> We don't need extension here, this file is internal to glibc.
>
> Thanks, I wasn't sure.


> Fixed below.  I've also cvs added the truncate64 files mentioned in
> the ChangeLog but that hadn't made it to my earlier cvs diff, so I'll
> ask for approval again.  No other files were modified.  Ok?

Ok,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj at suse dot de
   private aj at arthur dot inka dot de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]