This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

tmpfile64 on i386-gnu


This is a patch to make tmpfile64 work on i386-gnu.  When the weak_alias
happens after the #undef tmpfile, it's trying to make a weak_alias to an
undefined symbol (which causes it to silently do nothing)

I was surprised to see that tmpfile64 is a versioned symbol on
i386-linux, but just a weak alias here.  I know for other things, we've
tried to keep them the same, so that may be a different bug.

Also, do you want patches to remove USE_IN_LIBIO guards now that it's
hardcoded?

In the meantime, this gives us tmpfile64 again:

2003-04-25  Jeff Bailey  <jbailey at gnu dot org>

	* sysdeps/mach/hurd/tmpfile.c: move tmpfile64 weak_alias before
	#undef tmpfile.

--- sysdeps/mach/hurd/tmpfile.c.old       2003-04-25 08:27:41.000000000 -0400
+++ sysdeps/mach/hurd/tmpfile.c   2003-04-25 08:27:54.000000000 -0400
@@ -68,10 +68,10 @@
   return f;
 }
  
+weak_alias (tmpfile, tmpfile64)
+
 #ifdef USE_IN_LIBIO
 # undef tmpfile
 # include <shlib-compat.h>
 versioned_symbol (libc, __new_tmpfile, tmpfile, GLIBC_2_1);
 #endif
-
-weak_alias (tmpfile, tmpfile64)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]