Re: struct pthread_functions change breaks Wine

[Jakub Jelinek <jakub at redhat dot com>]

On Wed, Sep 10, 2003 at 01:25:26PM -0700, Alexandre Julliard wrote:
> The following change to the pthread_functions structure breaks Wine,
> because we define that structure internally to redirect pthread
> functions to our own wrappers. Now I know that we are not supposed to
> do that, but we don't really have a choice if we want to use libc
> functions from Win32 threads.
> 
> Would it be possible to move the new function to the end of the
> structure, so that we can add it in Wine while remaining backwards
> compatible?

Do you use look just into linuxthreads' one or NPTL as well?
If just linuxthreads, I'd say we can move it, linuxthreads is dying.

> --- pthread-functions.h	20 Apr 2003 07:37:06 -0000	1.1
> +++ pthread-functions.h	2 Sep 2003 00:36:28 -0000	1.2
> @@ -54,6 +54,8 @@ struct pthread_functions
>  				  const pthread_condattr_t *);
>    int (*ptr___pthread_cond_signal) (pthread_cond_t *);
>    int (*ptr___pthread_cond_wait) (pthread_cond_t *, pthread_mutex_t *);
> +  int (*ptr___pthread_cond_timedwait) (pthread_cond_t *, pthread_mutex_t *,
> +				       const struct timespec *);
>    int (*ptr_pthread_equal) (pthread_t, pthread_t);
>    void (*ptr___pthread_exit) (void *);
>    int (*ptr_pthread_getschedparam) (pthread_t, int *, struct sched_param *);
> 

	Jakub