This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: PATCH: Fix gcc/configure.in (Re: configure script breakage)
On Thu, Sep 11, 2003 at 09:08:00AM -0700, H. J. Lu wrote:
> On Thu, Sep 11, 2003 at 02:51:06PM +0200, Jakub Jelinek wrote:
> > On Thu, Sep 11, 2003 at 05:18:43PM +1000, Greg Schafer wrote:
> > > Hi
> > >
> > > 2 days ago I started seeing new testsuite failures when compiling the glibc
> > > trunk. I'm using the latest gcc-3_3-branch compiler to compile it.
> > >
> > > It looks to me like a patch went into the gcc branch a few days ago which
> > > has broken the glibc autoconf test for "__attribute__((visibility()))".
> > >
> > > It used to say:-
> > >
> > > "checking whether __attribute__((visibility())) is supported... yes"
> > >
> > > now it says "no".
> > >
> > > config.log shows:-
> > >
> > > conftest.c:1: warning: visibility attribute not supported in this configuration; ignored
> > > +conftest.c:2: warning: visibility attribute not supported in this configuration; ignored
> > >
> > > This may well be a gcc problem and I'm still looking into it. But I just
> > > wanted to raise the alarm to possibly save some poor soul from wasting hours
> > > of investigation like I just have.
> >
> > It is a bug in the recent gcc/configure{.in,} checkin, just back it out and
> > be happy.
> >
>
> This patch seems to fix it. OK to install?
>
>
> H.J.
> ---
> 2003-09-11 H.J. Lu <hongjiu.lu@intel.com>
>
> * configure.in (gcc_cv_ld_hidden): Check $gnu_ld before
> disabling it.
> * configure: Rebuild.
Where is gnu_ld ever defined?
grep gnu_ld gcc-3.3/configure{.in,}
configure.in:gnu_ld_flag="$with_gnu_ld",
configure.in:gnu_ld_flag=no)
configure.in: gnu_ld_flag=yes
configure.in: if test x"$gnu_ld_flag" = x"no"; then
configure.in:if test x"$gnu_ld_flag" = x"no"; then
configure:if test "${with_gnu_ld+set}" = set; then
configure: withval="$with_gnu_ld"
configure: gnu_ld_flag="$with_gnu_ld"
configure: gnu_ld_flag=no
configure: gnu_ld_flag=yes
configure: if test x"$gnu_ld_flag" = x"no"; then
configure:if test x"$gnu_ld_flag" = x"no"; then
You need to move the test a few lines above to if of the GNU ld test.
Jakub