This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: mktime.c fixes (part 5 of 6): fix boundary-condition overflows
- From: Ulrich Drepper <drepper at redhat dot com>
- To: Paul Eggert <eggert at CS dot UCLA dot EDU>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Wed, 31 Dec 2003 15:14:10 -0800
- Subject: Re: mktime.c fixes (part 5 of 6): fix boundary-condition overflows
- Organization: Red Hat, Inc.
- References: <87y8stz8ct.fsf@penguin.cs.ucla.edu>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Paul Eggert wrote:
> This patch is the heart of the fixes to mktime.c. I went through the
> code and carefully looked for all overflow problems, and fixed them.
There is no chance I'll apply this without you showing what the problems
are, that the old code has problems, and that the new code fixes it.
Provide a test suite which shows the problems. If you cannot do this
there is no need for the patch.
- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
iD8DBQE/81hC2ijCOnn/RHQRAkOSAKC543CmBcusxJzm7bqYPTZ7Gli+ygCfSZXe
D0y4YwD6GaBkyaKbdNNAkyo=
=dDXt
-----END PGP SIGNATURE-----