This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Adding m32r-linux support to glibc.


Some random comments on the patch itself below:

Kazuhiro Inaoka <inaoka.kazuhiro@renesas.com> writes:

> [...]
> diff -rcN ../libc-org/sysdeps/m32r/dl-machine.h ./sysdeps/m32r/dl-machine.h
> *** ../libc-org/sysdeps/m32r/dl-machine.h	Thu Jan  1 09:00:00 1970
> --- ./sysdeps/m32r/dl-machine.h	Thu Dec 25 20:16:03 2003
> ***************
> *** 0 ****
> --- 1,785 ----
> + /* Machine-dependent ELF dynamic relocation inline functions.  M32R version.
> +    Copyright (C) 2003 Free Software Foundation, Inc.
> +    This file is part of the GNU C Library.
> + 
> +    The GNU C Library is free software; you can redistribute it and/or
> +    modify it under the terms of the GNU Library General Public License as
> +    published by the Free Software Foundation; either version 2 of the
> +    License, or (at your option) any later version.
> + 
> +    The GNU C Library is distributed in the hope that it will be useful,
> +    but WITHOUT ANY WARRANTY; without even the implied warranty of
> +    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the GNU
> +    Library General Public License for more details.
> + 
> +    You should have received a copy of the GNU Library General Public
> +    License along with the GNU C Library; see the file COPYING.LIB.  If not,
> +    write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
> +    Boston, MA 02111-1307, USA.	*/
> + 
> + #ifndef dl_machine_h
> + #define dl_machine_h
> + 
> + /* Only dummy. This doesn't work. */

What does not work?  This is bad and you shouldn't submit anything
that does not work.

> + 
> + #define ELF_MACHINE_NAME "M32R"
> + 
> + #include <sys/param.h>
> + 
> + #include <assert.h>
> + 
> + /* Define the M32R_OLD_ABI, if you want to keep compatibility with
> +   an old Renesas relocs */
> + #ifdef M32R_OLD_ABI

Please remove the old code completly.

> [...]
> + #if 0 /* 20021129 1 -> 0 */

Please remove #if 0s and

> + 	case R_M32R_32:
> + 	  *reloc_addr = value;
> + 	  break;
> + #endif /* 20021129 1 -> 0 */
> + #ifdef M32R_OLD_ABI
> + 	case R_M32R_JMP_SLOT_SAMPLE:
> + #endif
> + 	case R_M32R_JMP_SLOT:
> + 	  elf_machine_fixup_plt(map, 0, reloc, reloc_addr, value);
> + 	  break;
> + #if 1 /* 20021129 0 -> 1 */

also #if 1...

> diff -rcN ../libc-org/sysdeps/unix/sysv/linux/m32r/Versions ./sysdeps/unix/sysv/linux/m32r/Versions
> *** ../libc-org/sysdeps/unix/sysv/linux/m32r/Versions	Thu Jan  1 09:00:00 1970
> --- ./sysdeps/unix/sysv/linux/m32r/Versions	Thu Dec 25 10:01:57 2003
> ***************
> *** 0 ****
> --- 1,33 ----
> + libc {
> +   GLIBC_2.2 {

You're going to introduce these functions as GLIBC_2.3.4.

> diff -rcN ../libc-org/sysdeps/unix/sysv/linux/m32r/sys/tas.h ./sysdeps/unix/sysv/linux/m32r/sys/tas.h
> *** ../libc-org/sysdeps/unix/sysv/linux/m32r/sys/tas.h	Thu Jan  1 09:00:00 1970
> --- ./sysdeps/unix/sysv/linux/m32r/sys/tas.h	Thu Dec 25 10:05:27 2003
> ***************
> *** 0 ****
> --- 1,13 ----
> + #ifndef	_SYS_TAS_H
> + 
> + #define	_SYS_TAS_H	1
> + 
> + #include <features.h>
> + 
> + __BEGIN_DECLS
> + 
> + extern int tas(int *) __THROW;

Please add a space before the open brace - and it would be nice to
have a comment here...

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]