This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
[PATCH] PPC Linuxthreads, more typos in versioned symbols.
- From: Steve Munroe <sjmunroe at us dot ibm dot com>
- To: libc-alpha at sources dot redhat dot com
- Cc: dgm69 at us dot ibm dot com, janis187 at us dot ibm dot com, Segher Boessenkoof <segher at kernel dot crashing dot org>
- Date: Fri, 20 Feb 2004 16:24:38 -0600
- Subject: [PATCH] PPC Linuxthreads, more typos in versioned symbols.
- Organization: IBM LTC
- Reply-to: sjmunroe at vnet dot ibm dot com
The function name for __vmx_longjmp was missspelled which cuased
longjmp@GLIBC_2.3.4 to be undefined. Also the default_symbol_version
macros where being generated even when the functions they referenced
where not. So move the whole thing inside #ifdef SHARED. Plus some
formatting cleanup.
2004-02-20 Steven Munroe <sjmunroe@us.ibm.com>
* sysdeps/unix/sysv/linux/powerpc/ptlongjmp.c [SHARED]: Code only
valid for SHARED case. Correct spelling of __vmx_longjmp.
diff -urN libc23-cvstip-20040218/linuxthreads/sysdeps/unix/sysv/linux/powerpc/ptlongjmp.c libc23/linuxthreads/sysdeps/unix/sysv/linux/powerpc/ptlongjmp.c
--- libc23-cvstip-20040218/linuxthreads/sysdeps/unix/sysv/linux/powerpc/ptlongjmp.c 2004-02-13 23:16:09.000000000 -0600
+++ libc23/linuxthreads/sysdeps/unix/sysv/linux/powerpc/ptlongjmp.c 2004-02-20 13:54:41.000000000 -0600
@@ -19,7 +19,8 @@
#include <setjmp.h>
#include <bits/wordsize.h>
#include <shlib-compat.h>
-#if defined SHARED && SHLIB_COMPAT (libpthread, GLIBC_2_0, GLIBC_2_3_4)
+#if defined SHARED
+# if SHLIB_COMPAT (libpthread, GLIBC_2_0, GLIBC_2_3_4)
/* These functions are not declared anywhere since they shouldn't be
used at another place but here. */
@@ -39,14 +40,14 @@
__novmx__libc_longjmp (env, val);
}
-# if __WORDSIZE == 64
+# if __WORDSIZE == 64
symbol_version (__novmx_longjmp,longjmp,GLIBC_2.3);
symbol_version (__novmx_siglongjmp,siglongjmp,GLIBC_2.3);
-# else
+# else
symbol_version (__novmx_longjmp,longjmp,GLIBC_2.0);
symbol_version (__novmx_siglongjmp,siglongjmp,GLIBC_2.0);
-# endif
-#endif /* defined SHARED && SHLIB_COMPAT (libpthread, GLIBC_2_0, GLIBC_2_3_4) ) */
+# endif
+# endif /* SHLIB_COMPAT (libpthread, GLIBC_2_0, GLIBC_2_3_4) ) */
/* These functions are not declared anywhere since they shouldn't be
used at another place but here. */
@@ -55,16 +56,15 @@
extern void __vmx__libc_longjmp (sigjmp_buf env, int val)
__attribute__ ((noreturn));
-#ifdef SHARED
void __vmx_siglongjmp (sigjmp_buf env, int val)
{
__vmx__libc_siglongjmp (env, val);
}
-void __vmxlongjmp (jmp_buf env, int val)
+void __vmx_longjmp (jmp_buf env, int val)
{
__vmx__libc_longjmp (env, val);
}
-#endif
default_symbol_version (__vmx_longjmp,longjmp,GLIBC_2.3.4);
default_symbol_version (__vmx_siglongjmp,siglongjmp,GLIBC_2.3.4);
+#endif /* SHARED */