This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix alpha compilation failure


At Mon, 17 May 2004 10:58:41 -0700,
Ulrich Drepper wrote:
> > The current cvs failed to compile on alpha with linux kernel < 2.6.4,
> > because old version did not have __NR_{fstat,lstat,stat}64.  This
> > patch checks such syscalls are actually defined.
> 
> This patch is not correct.  The code should never set errno unless it's
> necessary.  It's allowed by the standard, yes, but we still don't do it.
> 
> Secondly, it would be good to introduce an appropriate __ASSUME_* macro.
>  I know, this is nothing you introduced but still, it needs fixing.

Thanks for your comment, exactly it should use __ASSUME_* macro. I
retry to submit patches later.

Regards,
-- gotom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]