This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: Fix alpha compilation failure
- From: GOTO Masanori <gotom at debian dot or dot jp>
- To: Ulrich Drepper <drepper at redhat dot com>
- Cc: GOTO Masanori <gotom at debian dot or dot jp>,Richard Henderson <rth at twiddle dot net>,libc-alpha at sources dot redhat dot com
- Date: Tue, 25 May 2004 23:22:57 +0900
- Subject: Re: Fix alpha compilation failure
- References: <81vfj1zk9o.wl@omega.webmasters.gr.jp><40A8FD51.5040708@redhat.com>
At Mon, 17 May 2004 10:58:41 -0700,
Ulrich Drepper wrote:
> > The current cvs failed to compile on alpha with linux kernel < 2.6.4,
> > because old version did not have __NR_{fstat,lstat,stat}64. This
> > patch checks such syscalls are actually defined.
>
> This patch is not correct. The code should never set errno unless it's
> necessary. It's allowed by the standard, yes, but we still don't do it.
>
> Secondly, it would be good to introduce an appropriate __ASSUME_* macro.
> I know, this is nothing you introduced but still, it needs fixing.
Thanks for your comment, exactly it should use __ASSUME_* macro. I
retry to submit patches later.
Regards,
-- gotom