This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
[PATCH] small i386/fcntl.c and getent fixes
- From: Thorsten Kukuk <kukuk at suse dot de>
- To: libc-alpha at sources dot redhat dot com
- Date: Wed, 7 Jul 2004 11:40:33 +0200
- Subject: [PATCH] small i386/fcntl.c and getent fixes
- Organization: SuSE Linux AG, Nuernberg, Germany
Hi,
here is a patch, which fixes some typos:
- getent: if we use unsigned UIDs/GIDs, we should print them as such.
- i386/fcntl.c: The goto statements are syntacticaly wrong.
Thorsten
2004-07-06 Thorsten Kukuk <kukuk@suse.de>
* nss/getent.c (print_group): Print GID as unsigned long.
(print_passwd): Print UID and GID as unsigned long.
* sysdeps/unix/sysv/linux/i386/fcntl.c (__fcntl_nocancel): Fix
goto statements.
Index: nss/getent.c
===================================================================
RCS file: /cvs/glibc/libc/nss/getent.c,v
retrieving revision 1.16
diff -u -u -r1.16 getent.c
--- nss/getent.c 31 Mar 2004 00:14:10 -0000 1.16
+++ nss/getent.c 6 Jul 2004 12:05:32 -0000
@@ -174,7 +174,7 @@
{
unsigned int i = 0;
- printf ("%s:%s:%ld:", grp->gr_name ? grp->gr_name : "",
+ printf ("%s:%s:%lu:", grp->gr_name ? grp->gr_name : "",
grp->gr_passwd ? grp->gr_passwd : "",
(unsigned long int) grp->gr_gid);
@@ -453,7 +453,7 @@
static inline void
print_passwd (struct passwd *pwd)
{
- printf ("%s:%s:%ld:%ld:%s:%s:%s\n",
+ printf ("%s:%s:%lu:%lu:%s:%s:%s\n",
pwd->pw_name ? pwd->pw_name : "",
pwd->pw_passwd ? pwd->pw_passwd : "",
(unsigned long int) pwd->pw_uid,
Index: sysdeps/unix/sysv/linux/i386/fcntl.c
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/i386/fcntl.c,v
retrieving revision 1.19
diff -u -u -r1.19 fcntl.c
--- sysdeps/unix/sysv/linux/i386/fcntl.c 6 Jul 2004 04:11:05 -0000 1.19
+++ sysdeps/unix/sysv/linux/i386/fcntl.c 6 Jul 2004 12:30:04 -0000
@@ -75,7 +75,7 @@
fl.l_len = (off_t) fl64->l_len;
/* Check if we can represent the values with the smaller type. */
if ((off64_t) fl.l_len != fl64->l_len)
- goto eoverflow:
+ goto eoverflow;
fl.l_type = fl64->l_type;
fl.l_whence = fl64->l_whence;
@@ -103,7 +103,7 @@
fl.l_start = (off_t) fl64->l_start;
/* Check if we can represent the values with the smaller type. */
if ((off64_t) fl.l_start != fl64->l_start)
- goto eoverflow:
+ goto eoverflow;
fl.l_len = (off_t)fl64->l_len;
/* Check if we can represent the values with the smaller type. */
--
Thorsten Kukuk http://www.suse.de/~kukuk/ kukuk@suse.de
SuSE Linux AG Maxfeldstr. 5 D-90409 Nuernberg
--------------------------------------------------------------------
Key fingerprint = A368 676B 5E1B 3E46 CFCE 2D97 F8FD 4E23 56C6 FB4B