Re: bring mips*-linux back to a buildable state

[Andreas Jaeger <aj at suse dot de>]

Alexandre Oliva <aoliva@redhat.com> writes:

> On Jul 19, 2004, Andreas Jaeger <aj@suse.de> wrote:
>
>> Alexandre Oliva <aoliva@redhat.com> writes:
>>> These patches gets all 3 ABIs of mips64-linux to build and work again.
>
>> Can you send them separtly, so that it's easier to comment on them?
>
> Sure.  Here's the first one.  GCC 3.4 introduced a change in the way
> it defines built-in ABI macros.  Before 3.4, it used to define
> _MIPS_SIM_ABI32 when compiling for o32, so we could use _MIPS_SIM ==
> _MIPS_SIM_ABI32 to test whether we were generating code for o32.  Even
> when compiling for other ABIs, when _MIPS_SIM_ABI32 was not defined,
> the preprocessor would get the result of the compare right, since it
> would then regard the undefined identifier as 0, and _MIPS_SIM never
> equals 0.
>
> The change in GCC required me to give up on the shortcut I'd taken to
> avoid having to include sgidefs.h everywhere that referenced
> _MIPS_SIM.  This patch implements the changes in glibc to make sure
> every time we reference any other the _MIPS_SIM_* macros, sgidefs.h
> has already been included.

And that way it will work with GCC 3.3, 3.4 and 3.5 correctly?

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature