This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
array of incomplete structure is invalid
- From: Richard Henderson <rth at twiddle dot net>
- To: libc-alpha at gcc dot gnu dot org
- Date: Sun, 6 Feb 2005 19:08:32 -0800
- Subject: array of incomplete structure is invalid
These constructs are pedantically incorrect. Gcc *may* end up re-instating
some subset as an extension, but it's easy enough to avoid the ocurrences in
the first place.
r~
* iconvdata/jis0208.h (struct jisx0208_ucs_idx): Move before use.
nptl/
* sysdeps/pthread/pthread.h (__sigsetjmp): Use pointer as first
argument.
Index: iconvdata/jis0208.h
===================================================================
RCS file: /cvs/glibc/libc/iconvdata/jis0208.h,v
retrieving revision 1.9
diff -c -p -d -r1.9 jis0208.h
*** iconvdata/jis0208.h 11 Jun 2003 21:40:42 -0000 1.9
--- iconvdata/jis0208.h 7 Feb 2005 03:04:24 -0000
***************
*** 24,38 ****
#include <gconv.h>
#include <stdint.h>
- /* Conversion table. */
- extern const uint16_t __jis0208_to_ucs[];
-
- extern const char __jisx0208_from_ucs4_lat1[256][2];
- extern const char __jisx0208_from_ucs4_greek[0xc1][2];
- extern const struct jisx0208_ucs_idx __jisx0208_from_ucs_idx[];
- extern const char __jisx0208_from_ucs_tab[][2];
-
-
/* Struct for table with indeces in UCS mapping table. */
struct jisx0208_ucs_idx
{
--- 24,29 ----
*************** struct jisx0208_ucs_idx
*** 42,47 ****
--- 33,47 ----
};
+ /* Conversion table. */
+ extern const uint16_t __jis0208_to_ucs[];
+
+ extern const char __jisx0208_from_ucs4_lat1[256][2];
+ extern const char __jisx0208_from_ucs4_greek[0xc1][2];
+ extern const struct jisx0208_ucs_idx __jisx0208_from_ucs_idx[];
+ extern const char __jisx0208_from_ucs_tab[][2];
+
+
static inline uint32_t
__attribute ((always_inline))
jisx0208_to_ucs4 (const unsigned char **s, size_t avail, unsigned char offset)
Index: nptl/sysdeps/pthread/pthread.h
===================================================================
RCS file: /cvs/glibc/libc/nptl/sysdeps/pthread/pthread.h,v
retrieving revision 1.30
diff -c -p -d -r1.30 pthread.h
*** nptl/sysdeps/pthread/pthread.h 24 Nov 2004 22:55:24 -0000 1.30
--- nptl/sysdeps/pthread/pthread.h 7 Feb 2005 03:04:24 -0000
*************** extern void __pthread_unwind_next (__pth
*** 661,667 ****
/* Function used in the macros. */
struct __jmp_buf_tag;
! extern int __sigsetjmp (struct __jmp_buf_tag __env[1], int __savemask) __THROW;
/* Mutex handling. */
--- 661,667 ----
/* Function used in the macros. */
struct __jmp_buf_tag;
! extern int __sigsetjmp (struct __jmp_buf_tag *__env, int __savemask) __THROW;
/* Mutex handling. */