This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
[PATCH] Don't include <asm/types.h> in ppc64 sys/ucontext.h
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Ulrich Drepper <drepper at redhat dot com>, sjmunroe at us dot ibm dot com
- Cc: libc-alpha at sources dot redhat dot com
- Date: Mon, 14 Mar 2005 10:18:53 -0500
- Subject: [PATCH] Don't include <asm/types.h> in ppc64 sys/ucontext.h
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
Hi!
The include from what I gathered doesn't serve any useful purpose there
(all types but struct pt_regs * are already defined in that header,
and struct pt_regs is not defined in asm/types.h nor is desirable to
define it in sys/ucontext.h).
As <asm/types.h> defines umode_t type, this causes some programs
to fail to compile on ppc64.
2005-03-14 Jakub Jelinek <jakub@redhat.com>
* sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h: Don't include
asm/types.h.
--- libc/sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h.jj 2004-01-27 15:44:26.000000000 +0100
+++ libc/sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h 2005-03-14 15:56:39.725704967 +0100
@@ -1,4 +1,4 @@
-/* Copyright (C) 1998, 1999, 2002, 2004 Free Software Foundation, Inc.
+/* Copyright (C) 1998, 1999, 2002, 2004, 2005 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -70,8 +70,6 @@ typedef struct
* can be refernced safely only after verifying that PPC_FEATURE_HAS_ALTIVEC
* is set in AT_HWCAP. */
-# include <asm/types.h>
-
/* Number of general registers. */
# define NGREG 48 /* includes r0-r31, nip, msr, lr, etc. */
# define NFPREG 33 /* includes fp0-fp31 &fpscr. */
Jakub