This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] avoid double Nul termination


On Mon, Jun 13, Ulrich Drepper wrote:

> Thorsten Kukuk wrote:
> > 	[BZ #962]
> > 	* nis/nss_nis/nis-netgrp.c (_nss_nis_setnetgrent): Remove
> > 	double Nul termination.
> 
> I'm not going to apply this.  If the test fails, there is a bug
> somewhere.  It's ridiculous to even see this patch proposed.  If there
> is a bug it doesn't go away by ignoring it.

I agree that there is a bug somewhere else. But the code is useless,
the data is always Nul terminated, there is no need to do that twice.

-- 
Thorsten Kukuk         http://www.suse.de/~kukuk/      kukuk@suse.de
SUSE LINUX Products GmbH       Maxfeldstr. 5       D-90409 Nuernberg
--------------------------------------------------------------------    
Key fingerprint = A368 676B 5E1B 3E46 CFCE  2D97 F8FD 4E23 56C6 FB4B


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]