This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
I've added the patch but had to change quite a lot. It was less work to do it myself than to explain it but please compare the new code with your patch to see what should have been done. A few notes I took: - copyright years were not updates. Roland's upd-copyr.el does this automatically. - still many formatting errors. Including the changelog. - lots of whitespaces at end of lines. In one case even after the backslash which is meant to continue a macro definition on the next line. Use whitespace.el in emacs or equivalent tools for your editor - in dl-start.c, there are multiple ENTRY uses. All but the first are no real entry symbols. The ppc ENTRY macro doesn't use cfi_startproc yet but it should and then this is a real problem. - if you copy a generic file and modify it, then at least change the "Generic" in the first line - export symbols or better one table? In any case, these are Linux specific definitions and therefore the export must be in a Linux specific Versions file - the macros in sysdep.h did the error checking wrong. You cannot just compare the return value. Didn't you look at the INTERNAL_SYSCALL_ERROR_P macro etc? - when using local label, some of the macros can be optimized - I've renamed some of the sysdep.h macros and removed others which are not needed. There should be two kinds: INTERNAL_* and INLINE_*. The normal and vdso versions should have the same semantics. It's fine to have the INTERNAL_VSYSCALL_NO_SYSCALL_FALLBACK since it's useful. But again, the semantics must match the other INTERNAL_* macros. -- â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
Attachment:
signature.asc
Description: OpenPGP digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |