This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: wprintf/vfprintf.c vs. large precision: allocates far too much memory

From: Ulrich Drepper <drepper at redhat dot com>
To: Jim Meyering <jim at meyering dot net>
Cc: libc-alpha at sourceware dot org
Date: Sun, 06 May 2007 20:45:31 -0700
Subject: Re: wprintf/vfprintf.c vs. large precision: allocates far too much memory
References: <87vef7qnf1.fsf@rho.meyering.net> <20070505172326.28090.qmail@md.dent.med.uni-muenchen.de> <87ps5fqd9b.fsf@rho.meyering.net>

Jim Meyering wrote:

-	    len = prec != -1 ? (size_t) prec : strlen (mbs);		      \
+	    len = strlen (mbs);						      \
+	    if (prec != -1)						      \
+	      len = (size_t) prec;					      \

The right thing to do is to use strnlen(). See the code I checked in.

--
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â

References:
- wprintf/vfprintf.c vs. large precision: allocates far too much memory
  - From: Jim Meyering
- Re: wprintf/vfprintf.c vs. large precision: allocates far too much memory
  - From: Wolfram Gloger
- Re: wprintf/vfprintf.c vs. large precision: allocates far too much memory
  - From: Jim Meyering

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]