This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fcntl.h should provide mode_t, off_t and pid_t


Roland McGrath, le Sun 13 Jul 2008 16:18:40 -0700, a écrit :
> > > If it is missing only in Hurd configurations, we should figure out how
> > > the difference arises before changing anything.
> > 
> > That's the difference.
> 
> Might as well just change the Hurd's bits/*.h headers to match the Linux
> ones in their <sys/types.h> use and not worry about it in detail.

Ok, then patch below.

> > BTW, I've actually just ended up generating systematic tests, and we
> 
> We have the stuff in conform/ for that.  I guess it's not used by make
> check or anything.

It's not indeed.

> May it's bit-rotted.  Would you like to work on fixing
> that up and making sure it will catch everything that you have observed?

fcntl.h missing pid_t on hurd was catched indeed, wchar.h missing
va_list wasn't, and there are a couple other things that are missing
(e.g. no fenv.h).  I may take some time to fix that later.

Samuel

2008-07-14  Samuel Thibault  <samuel.thibault@ens-lyon.org>

	* sysdeps/mach/hurd/bits/fcntl.h: Include <sys/types.h>

Index: sysdeps/mach/hurd/bits/fcntl.h
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/mach/hurd/bits/fcntl.h,v
retrieving revision 1.14
diff -u -p -r1.14 fcntl.h
--- sysdeps/mach/hurd/bits/fcntl.h	18 Nov 2007 22:51:16 -0000	1.14
+++ sysdeps/mach/hurd/bits/fcntl.h	14 Jul 2008 00:47:13 -0000
@@ -22,6 +22,8 @@
 # error "Never use <bits/fcntl.h> directly; include <fcntl.h> instead."
 #endif
 
+#include <sys/types.h>
+
 /* File access modes.  These are understood by io servers; they can be
    passed in `dir_lookup', and are returned by `io_get_openmodes'.
    Consequently they can be passed to `open', `hurd_file_name_lookup', and


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]