This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] make check failure patch and a typo clean up.
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: rsa at us dot ibm dot com
- Cc: "GNU libc devel" <libc-alpha at sources dot redhat dot com>, "Carlos Eduardo Seo" <cseo at linux dot vnet dot ibm dot com>
- Date: Thu, 21 Aug 2008 12:06:16 -0400
- Subject: Re: [PATCH] make check failure patch and a typo clean up.
- References: <1219270861.8790.27.camel@localhost>
On Wed, Aug 20, 2008 at 6:21 PM, Ryan S. Arnold <rsa@us.ibm.com> wrote:
> While cleaning up make check we ran across a few issues
> for which we've provided the following patches.
>
> 1.) Patch 1 prevents an infrequent make check failure
> caused by two runs of make check stomping on each other's
> temp file usage.
Wouldn't one or more simultaneous `make check' runs write to the same
test output file?
Please explain.
> 2.) Patch 2 fixes a typo on an internal symbol name.
This cleanup patch looks fine to me. It's only a typo in the name of
the macro, but the typo'd name is used consistently.
In the future you should really send the patches as separate emails.
Sending them in a single email makes me think they are somehow
related.
Cheers,
Carlos.