This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] sh: clone little optimization


"Carmelo Amoroso" <carmelo73@gmail.com> wrote:
> Please find below a new version of the patch with proper indentation
> for instruction in delayed slot a required Changelog, hopefully now it's ok.

It seems that all tabs in the new patch are replaced with
4 spaces.  Perhaps the mailer problem?

> 2008-08-27 Carmelo Amoroso <carmelo.amoroso@st.com>
> 
>         * sysdeps/unix/sysv/linux/sh/clone.S: change the
>         branch instruction with a delayed branch so that
>         the r3 register can be loaded into a delayed slot.

Two spaces are needed before and after the full name.
Also the ChangeLog entry should use a tab instead of 8
spaces and the description should start with a capital
letter:

2008-08-27  Carmelo Amoroso  <carmelo.amoroso@st.com>

        * sysdeps/unix/sysv/linux/sh/clone.S (__clone): Change
	the branch instruction with a delayed branch so that
        the r3 register can be loaded into a delayed slot.

Regards,
	kaz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]