This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix ____longjmp_chk for ppc(64)

On Wed, Jun 24, 2009 at 10:28:39AM -0700, Richard Henderson wrote:
> On 06/24/2009 10:15 AM, Jakub Jelinek wrote:
> >  	bl	HIDDEN_JUMPTARGET (__fortify_fail);	\
> >  .Lok:							\
> >	mr	r1, reg;				\
> >+	cfi_adjust_cfa_offset (-112);			\
> >+	cfi_same_value (lr)
> >
> >and remove the mr r1, r14 resp. mr r1, r22 from __longjmp-common.S?
> >Then you don't need to add any extra insn.
> 
> The cfa is incorrect for the duration of the mr r1 insn.

Which mr - the one Jakub quoted above or the one in
__longjmp-common.S?  IIUC the CFI doesn't attach to the mr
in the above, but to the following instruction.  So I don't understand
why the nop is required.

-- 
Daniel Jacobowitz
CodeSourcery
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]