This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: power7-optimized classification functions
- From: Ulrich Drepper <drepper at redhat dot com>
- To: libc-alpha at sourceware dot org
- Date: Sat, 06 Feb 2010 02:32:08 -0800
- Subject: Re: [PATCH] powerpc: power7-optimized classification functions
- References: <1265310318.5398.175.camel@gargoyle>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/04/2010 11:05 AM, Luis Machado wrote:
> +++ b/sysdeps/powerpc/powerpc32/power7/fpu/s_finite.S
> @@ -0,0 +1,95 @@
> +/* finite(). PowerPC32 version.
But this is no ppc32 version. It's a ppc32/power7 version. This
applies to all the files.
> + Copyright (C) 2010 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + Author: Luis Machado <luisgpm@br.ibm.com>
Look at the other files in the source tree. We have
Written by xyz <...>.
(or Contributed etc) lines immediately after the copyright. No
whitespace. Don't invent something new.
> +/* int __finite(x) */
> + .section .rodata.cst4,"aM",@progbits,4
> + .align 3
> +.LC0: /* 1.0 */
> + .quad 0x3ff0000000000000
These are 8-byte constants and you mark the section as const with width 4?
> +# ifdef HAVE_ASM_PPC_REL16
- From what I've seen this is something introduced in June 2005. Time to
move on and declare old binutils unusable.
All the other uses of the symbol should go, too. In a separate patch.
- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkttRSgACgkQ2ijCOnn/RHRZ5QCeIospS4J9pq4owK69HfngT7IH
hsUAn3+XFPSAwIkBB3fLl40+wjoSThFJ
=uaxt
-----END PGP SIGNATURE-----