This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: Fix POWER7 Implies


Hi,

I've updated the patch with a few modifications. Turns out we only need
these two files changed:

sysdeps/unix/sysv/linux/powerpc/powerpc32/power7/fpu/Implies
sysdeps/unix/sysv/linux/powerpc/powerpc64/power7/fpu/Implies

The other files inside sysdeps/powerpc/powerpc[32|64]/power7/ and
sysdeps/powerpc/powerpc[32|64]/power7/fpu are not required, so i went
ahead and removed them to make things cleaner.

Makes sense?

It picks up all power7-specific string and math routines, and, when
those are not available, it picks whatever is compatible.

Regtested on ppc32/64.

Regards,
Luis

On Thu, 2010-02-04 at 10:24 -0800, Ulrich Drepper wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 02/04/2010 10:06 AM, Luis Machado wrote:
> > The following patch sets the correct values for the power7 implies files
> > diff --git a/sysdeps/powerpc/powerpc32/power7/Implies b/sysdeps/powerpc/powerpc32/power7/Implies
> > index 03899d8..1c5de72 100644
> > --- a/sysdeps/powerpc/powerpc32/power7/Implies
> > +++ b/sysdeps/powerpc/powerpc32/power7/Implies
> > @@ -1 +1,2 @@
> > +powerpc/powerpc32/power7
> >  powerpc/powerpc32/power5
> > diff --git a/sysdeps/powerpc/powerpc64/power7/Implies b/sysdeps/powerpc/powerpc64/power7/Implies
> > index 13b0330..2bb20bf 100644
> > --- a/sysdeps/powerpc/powerpc64/power7/Implies
> > +++ b/sysdeps/powerpc/powerpc64/power7/Implies
> > @@ -1 +1,2 @@
> > +powerpc/powerpc64/power7
> >  powerpc/powerpc64/power5
> 
> 
> These make no sense whatsoever.  If the Implies file is found the
> directory is added, too.  It's the same directory.  If this "fixes"
> something there is something else wrong.
> 
> - -- 
> â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
> 
> iEYEARECAAYFAktrENMACgkQ2ijCOnn/RHQfQwCfcXQTLqwOGwmiRgd2km26Ce5W
> MFkAnjgF/Dn9NI+shp+ypPfRrGYK/F67
> =EQKr
> -----END PGP SIGNATURE-----


2010-02-10  Luis Machado  <luisgpm@br.ibm.com>

        * sysdeps/powerpc/powerpc64/power7/Implies: Remove unneeded file.
	* sysdeps/powerpc/powerpc64/power7/fpu/Implies: Likewise.
	* sysdeps/powerpc/powerpc32/power7/Implies: Likewise.
	* sysdeps/powerpc/powerpc32/power7/fpu/Implies: Likewise.
        * sysdeps/unix/sysv/linux/powerpc/powerpc64/power7/fpu/Implies: Add
          64-bit power7 fpu path.
        * sysdeps/unix/sysv/linux/powerpc/powerpc32/power7/fpu/Implies: Add
          32-bit power7 fpu math.

diff --git a/sysdeps/powerpc/powerpc32/power7/Implies b/sysdeps/powerpc/powerpc32/power7/Implies
deleted file mode 100644
index 03899d8..0000000
--- a/sysdeps/powerpc/powerpc32/power7/Implies
+++ /dev/null
@@ -1 +0,0 @@
-powerpc/powerpc32/power5
diff --git a/sysdeps/powerpc/powerpc32/power7/fpu/Implies b/sysdeps/powerpc/powerpc32/power7/fpu/Implies
deleted file mode 100644
index 819a7d7..0000000
--- a/sysdeps/powerpc/powerpc32/power7/fpu/Implies
+++ /dev/null
@@ -1 +0,0 @@
-powerpc/powerpc32/power5/fpu
diff --git a/sysdeps/powerpc/powerpc64/power7/Implies b/sysdeps/powerpc/powerpc64/power7/Implies
deleted file mode 100644
index 13b0330..0000000
--- a/sysdeps/powerpc/powerpc64/power7/Implies
+++ /dev/null
@@ -1 +0,0 @@
-powerpc/powerpc64/power5
diff --git a/sysdeps/powerpc/powerpc64/power7/fpu/Implies b/sysdeps/powerpc/powerpc64/power7/fpu/Implies
deleted file mode 100644
index 13b0330..0000000
--- a/sysdeps/powerpc/powerpc64/power7/fpu/Implies
+++ /dev/null
@@ -1 +0,0 @@
-powerpc/powerpc64/power5
diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/power7/fpu/Implies b/sysdeps/unix/sysv/linux/powerpc/powerpc32/power7/fpu/Implies
index d379a2d..af94611 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/power7/fpu/Implies
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/power7/fpu/Implies
@@ -1,3 +1,4 @@
 # Make sure this comes before the powerpc/powerpc32/fpu that's
 # listed in unix/sysv/linux/powerpc/powerpc32/fpu/Implies.
+powerpc/powerpc32/power7/fpu
 powerpc/powerpc32/power5/fpu
diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/power7/fpu/Implies b/sysdeps/unix/sysv/linux/powerpc/powerpc64/power7/fpu/Implies
index c46b3d4..ca11220 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/power7/fpu/Implies
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/power7/fpu/Implies
@@ -1,3 +1,4 @@
 # Make sure this comes before the powerpc/powerpc64/fpu that's
 # listed in unix/sysv/linux/powerpc/powerpc64/fpu/Implies.
+powerpc/powerpc64/power7/fpu
 powerpc/powerpc64/power5/fpu



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]