This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] powerpc: Cleanup old obsolete PPC_REL16 checks

From: Ulrich Drepper <drepper at redhat dot com>
To: luisgpm at linux dot vnet dot ibm dot com
Cc: libc-alpha at sourceware dot org
Date: Thu, 11 Feb 2010 06:59:10 -0800
Subject: Re: [PATCH] powerpc: Cleanup old obsolete PPC_REL16 checks
References: <1265653402.5398.187.camel@gargoyle> <4B71AA53.7040503@redhat.com> <1265899897.26043.5.camel@gargoyle>

On 02/11/2010 06:51 AM, Luis Machado wrote:

Should the test be binutils-version-oriented (we already fail based on
Binutil's version number IIRC)? Or should I just fail if PPC_REL16 is
not supported with a message like "gas doest not support PPC_REL16.
Binutil is too old."?

I'm inclined to take the second approach.

The latter. Just keep the existing test mostly intact. Instead of defining a macro simply fail if the support isn't there.

--
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â

Follow-Ups:
- Re: [PATCH] powerpc: Cleanup old obsolete PPC_REL16 checks
  - From: Luis Machado

References:
- [PATCH] powerpc: Cleanup old obsolete PPC_REL16 checks
  - From: Luis Machado
- Re: [PATCH] powerpc: Cleanup old obsolete PPC_REL16 checks
  - From: Ulrich Drepper
- Re: [PATCH] powerpc: Cleanup old obsolete PPC_REL16 checks
  - From: Luis Machado

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]