This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Replace divide and multiply with mask in sYSTRIm

From: Anton Blanchard <anton at samba dot org>
To: Andreas Schwab <schwab at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Mon, 26 Jul 2010 23:51:22 +1000
Subject: Re: [PATCH] Replace divide and multiply with mask in sYSTRIm
References: <20100726043651.GE29316@kryten><20100726072109.GA1696@kryten><m34ofm1jig.fsf@hase.home>

Hi Andreas,

> > -  extra = ((top_size - pad - MINSIZE + (pagesz-1)) / pagesz - 1) * pagesz;
> > +  extra = (top_size - pad - MINSIZE + (pagesz-1)) & ~(pagesz-1);
> 
> That's not the same.  Your version is off by pagesz.

Ouch, thanks for catching that. Will fix and resend.

Anton

References:
- [PATCH] Replace divide and multiply with mask in sYSTRIm
  - From: Anton Blanchard
- Re: [PATCH] Replace divide and multiply with mask in sYSTRIm
  - From: Anton Blanchard
- Re: [PATCH] Replace divide and multiply with mask in sYSTRIm
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]