This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] Avoid duplication of _CLOEXEC and _NONBLOCK values


On Fri, 13 Aug 2010, Ulrich Drepper wrote:

> There just is no reason whatsoever to do any of this.

The fact that the SPARC versions of sys/inotify.h, sys/epoll.h and 
sys/eventfd.h are out of sync with the generic Linux versions shows quite 
clearly that something should be changed, as updates to the SPARC versions 
of these files - in libc, not ports - are being missed when the generic 
versions are updated, so the present system for maintaining these files is 
not in fact working.

I suggest that the reason it is not working is that the presence of 
multiple copies of these sys/* files violates the expectation that only 
bits/* files require versions for multiple target architectures to be 
updated - the prototypes and architecture-independent definitions should 
be in the present sys/* headers, but the _CLOEXEC and _NONBLOCK values 
should be in bits/* headers, and only the bits/* headers would be 
duplicated for multiple targets, so making it much more obvious which 
changes require target headers to be updated.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]