This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Handle various cache size
- From: Ulrich Drepper <drepper at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 7 Sep 2010 19:50:25 -0400 (EDT)
- Subject: Re: PATCH: Handle various cache size
----- "H.J. Lu" <hongjiu.lu@intel.com> wrote:
> * sysdeps/i386/i686/multiarch/memset-sse2.S: Handle various
> cache size.
I don't like this. As Jakub mentioned elsewhere, doing this work all the time the function is called is unnecessarily expensive. I haven't looked how exactly the code uses the cache size. My guess is that odd cache sizes can be handled in some way without additional overhead.
If this is not the case then a special new variable should be introduced in cacheinfo. Then the memset code should use this rounded cache size variable.
--
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â