This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: Use generic memset for RTLD for ppc32/64


On Mon, 2010-09-27 at 23:56 -0400, Ulrich Drepper wrote:
> On Mon, Sep 27, 2010 at 23:12, Luis Machado <luisgpm@linux.vnet.ibm.com> wrote:
> > We use a cache-based instruction (dcbz) to optimize memset when it's
> > called with a 0 value (bzero). In short, we clear 128 bytes in a row and
> > move to the next iteration.
> 
> Then why not simply replace the 0x80 in the asm code with a macro?
> All these temporary workarounds and especially for architectures
> nobody but you care about.  You have control over the sources used for
> your own builds.  So just provide final patches.

It's not so simple. The code does pre-alignment to 128-bytes prior to
using the instruction, so those chunks of code need to be executed
conditionally.

Is estabilishing a power4 rtld-memset acceptable at all or would you
rather have the power4 memset code modified?

Luis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]