This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] make PowerPC64 default to nonexecutable stack
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: rsa at us dot ibm dot com
- Cc: libc-alpha at sourceware dot org
- Date: Sun, 26 Dec 2010 17:15:46 +0100
- Subject: Re: [PATCH] make PowerPC64 default to nonexecutable stack
- References: <1292463806.18510.14.camel@localhost.localdomain>
Ryan Arnold <rsa@us.ibm.com> writes:
> @@ -150,9 +151,13 @@ main (int argc, char *argv[])
> int cnt;
> int result = 0;
>
> - for (cnt = 1; cnt < argc; ++cnt)
> - result |= handle_file (argv[cnt]);
> -
> + /* We can return successfully, i.e., not fail, if PF_X isn't present. If it
> + * is present then check for the GNU_STACK header. */
> + if (DEFAULT_STACK_PERMS & PF_X)
> + {
That does not make sense. You always need to check the GNU_STACK
header.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."